Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Four card feature section using CSS Grid

@pankaj512

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi,

Happy New Year. May this year bring happiness and joy to your life.

Here is my solution for this challenge. Please provide your valuable feedback and suggestions. Happy coding :)

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Hi, Pankaj! Happy new year too!

Here are some suggestions for improvements.

  • Use visible heading instead of visually hidden heading. You can make "Reliable, efficient delivery powered by technology", as a <h1>.
  • Also, that text should be wrapped by one heading. It is a sentence.
  • Remove <h2 class="sr-only">Heading for section</h2>. There is no need to add visually hidden headings. (Try not to overthink accessibility.)
  • Setting display: none to .sr-only will hide the HTML element from everyone including assistive technologies. So, use the following styling instead for visually hidden class — Improved .sr-only
  • <section> and <article> have no semantic meanings unless you label them with aria-label or aria-labelledby. So, don't overuse them. You can replace them with <div> instead. Source: WebAIM: HTML Semantics and Accessibility Cheat Sheet

I hope this helps. Happy coding too!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord