Four Card Feature Section

Community feedback

• 

  dewslyse•3,025

  @dewslysePosted over 3 years ago

  Hello Sravan 👋! Congrats on your submission. Nice and responsive across devices.

  Try manipulating the values of the box-shadow property. Start with something like box-shadow: 0 2px 20px 5px rgba(0, 0, 0, 30%); and keeping altering till you get it to look how you want it.

  You should also try and resolve the accessibility issues raised in the report

  Marked as helpful

  2

  ---

  

  Sravan•220

  @SravanSTGPosted over 3 years ago

  Hello @dewslyse! Resolved all the accessibility issues, and box-shadow looks better now.

  Thank you! 🙂

  1

  

  dewslyse•3,025

  @dewslysePosted over 3 years ago

  @SravanSTG

  Super!! Best of luck with the subsequent challenges

  1
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  hello

  I'll add a little to that:

  Try not to build your layout using bespoke margins everywhere. You will have more maintainable results without % margins and by leveraging properties like max-width.

  I recommend centering content on the page using grid or flexbox, and zooming right out and in with devtools open to get a feel for what happens at the largest and smallest screen sizes

  The main heading on this should be one h1, not 2 h2s.

  Remember heading order really matters.

  Font size must never be in px. Use rem if possible, or sometimes em is suitable.

  Good luck

  Marked as helpful

  1

  ---

  

  Sravan•220

  @SravanSTGPosted over 3 years ago

  Hi @grace-snow! Thank you for the helpful insight. Good to know all these programming practices. I have updated the solution with some. And I will definitely keep in mind all these for future challenges.

  0