Four Card Feature Section

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Ivet,

  Well done :D

  I have checked your HTML structure and generally looks well, a few tips for you:

  • probably you know, but you can also create h1 with two spans named: main-heading and sub-heading;
  • instead of div class="container" you can use the tag main;
  • icons: they have only a decorative role - that's a reason why alt text should be provided as a empty (alt="") so these icons can be ignored by assistive technologies, such as screen readers;
  • RWD: you did it great (included mobiles, tablets, desktop) only I'd recommend to play a bit with the size of main heading on mobiles;
  • reset the styles in CSS folder by adding margin/padding set to 0 in the * selector;
  • you can center all content in the viewport and add overflow: hidden to the body (eliminate the scroll).

  That's from me. Ps. Don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1
• 

  Ivet•210

  @Ivet89Posted almost 4 years ago

  Thank you for your advices :)

  0