Design comparison
SolutionDesign
Solution retrospective
If You have any feedback I'm ready to hear it , it's gonna be so helpful.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
main
element should only ⚠️ be wrapping the card section since that is the main content of your page.
- The “Reliable, efficient delivery Powered by Technology” is one single heading ⚠️ so the entire thing should be wrapped in a single
h1
heading along with aspan
element.
- The intro heading and paragraph ⚠️ should be wrapped inside a
header
element.
- NEVER ❌ do this as it creates accessibility issues for users and it is outdated.
html { font-size: 15px; }
- To properly center ✅ your content to your page, you will want to add the following to your
body
(this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
More Info: 📚
- Using
CSS Grid
withGrid-Template-Areas
will make things way easier 💯 when building the layout; it will give you full control of the layout.
Here is an example of how it works: EXAMPLE
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0@MouradBouzgmaPosted almost 2 years ago@vcarames Thank You so Much ,I appreciate these Advices , I applied some of them and I will apply the others once I understand them .
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord