Four card feature, grid, flexbox, SASS, BEM and bad practices
Design comparison
Solution retrospective
This challenge make me do bad practice like use (!Important) and manipulate the grid with position, things that i think can be better.
Hope you can help me, any other feedback is welcome.
Community feedback
- @SStranksPosted over 3 years ago
I've only just started myself, but I think it's important to work out why you needed to use the !important, then go back and amend your code to avoid it.
When I attempted this one I created the cards at a fixed size in pixels and positioned them on a grid of 3 cols vs 2 rows, and then used span to make a card bridge the two rows so it was centred.
0 - @pikapikamartPosted over 3 years ago
Well I kinda feel bad for this, but sometimes I use !important as well haha but take not, I use them only when like I want an element to be none like display none with important on it, but not using it when just normal styling. For that position part, nothing wrong with although we could use the normal
transform: translate()
property on that so that we don't need to make our items relative when we don't really need it to be that way. Anyway good job on your challenge^0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord