Four card feature created with CSS Grid

Community feedback

• 

  Ahmed El_Bald•1,020

  @Ahmed-ElbaldPosted over 2 years ago

  Hey Padawan,

  I think your solution is great concerning using the right method (Flex or Grid) so you don't have to worry about that.

  But actually I have some notes on other aspects:

  • The top border of the card should be quite smaller. Its width could be just 5px
  • Also I would have been better if you'd used the colors in the "style-guide" file without modifying them.
  • And finally I think the box-shadow of the cards has a big spread. You can set the spread to zero and play around with the blur. Something like this 5px 5px 10px 0px var(--color-paragraph).

  I hope you find this helpful. Thank you

  Marked as helpful

  0

  ---

  

  Padawan•160

  @soitirakisPosted over 2 years ago

  @Ahmed-Elbald thank you very much for the feedback. I will look to it and make the proper changes. Happy coding

  0
• 

  faizan•2,420

  @afaiz-spacePosted over 2 years ago

  Hey @soitirakis, remove the padding from the container class.

  0

  ---

  

  Padawan•160

  @soitirakisPosted over 2 years ago

  @afaiz-space thank you for reviewing my code. I will look over it and I will make the change. Happy coding

  0