four card feature challenge mainly using CSS and some grid

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <header> element should includes the heading, any sub-headings, logo, author's name, and navigational links for the website.

  ---

  • So resolve the issue by replacing the <article> element with the proper semantic element <header> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi Caleb

  Please take note that the dimensions in the assets folder do not refer to media queries breakpoints, those are a presentation of how your work should look like at the given sizes. That is at the given sizes (375px and 1440px) , your site should look like the images. For breakpoints , it is your responsibility to decide - in short , your breakpoint should have been way earlier than the 1440px.

  Heading elements should follow a sequential order with the first heading element being an h1, then the next would be an h2. You should not start with an h3 and then go back to an h2.

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  make ur title in bold case or increase the fontwieght

  0
• 

  Mukwende•1,370

  @mukwende2000Posted over 1 year ago

  Check your code again and preview the site, you have set the @media (min-width: 1440px) which makes the flex styles of the max.container for the card to not display, reduce the min-width to something smaller otherwise everything is great, i actually tried, i used 768px instead of 1440px and it magically displayed properly...

  0