Four Card Feature

Community feedback

• 

  P

  Margaux•120

  @margaux-worksPosted 3 months ago

  Hi there,

  your solution looks great! Very close to the design which was provided, good job :)

  I checked your code, and found a few potential optimisations:

  • you could use <header> for your titles for a better semantic structure.
  • your card are mixed with <section> and <div>. You could have a better consistency by using section for all cards elements for example.
  • there is not alt attributes for your images
  • you could put all your reset rules in a separate css file (i.e reset.css) so that it gives more clarity on what is your personal style and what are the reset rules.

  I hope this helps! Keep up the good work :)

  Marked as helpful

  0