Four Card Feature - HTML, CSS

Community feedback

• 

  Eric Salvi•1,330

  @ericsalviPosted over 3 years ago

  Hey, this looks awesome. You implemented the cards a bit nicer than I did on this project.

  The background color of the cards seems a bit off. I believe they should be pure white but currently are a slightly different off-white. I would add to the end of the background-image CSS , #fff;

  Some improvements to the CSS is maybe to be a bit more semantic? https://www.w3schools.com/html/html5_semantic_elements.asp

  What I mean by that is instead of having a div with a class of main-container you could have just replaced the entire div with <main>. Maybe instead of a div around each of the cards you use <section>'s.

  Lastly if you really want to work on your class names, check out BEM naming conventions.

  1

  ---

  

  Giorgi Pasieshvili•300

  @GiorgiPasieshviliPosted over 3 years ago

  @ericsalvi thanks i really appreciate your advices

  0