Four Card Feature

Community feedback

• 

  P

  Lo-Deck•3,560

  @Lo-Deck

  Posted over 1 year ago

  Hi well done for this challenge.

  When I opened your website I can't scroll to see the whole page.

  There is overflow: hidden on the body, need to erase it to scroll again.

  And if you want to know a good tool to help you to have a good responsiveness when you resize. Here is a link.Utopia

  Read it and it explain how to use clamp() for margin, padding, spaces ...

  Hope to be helpful.

  10

  Marked as helpful
• 

  Dylan Guaquier•340

  @dylanguaquier

  Posted over 1 year ago

  Hey, i've put myself the overflow-y hidden on media queries 1440px cause there is no need to scroll here on desktop but yeah, i understand.

  I mean if that's a component, media queries should be on the component itself and nowhere else :/. That is also mean that the background-color or padding on the body shouldn't be useful on this types of challenge.

  And thanks a lot for clamp() i have no clue about what this is, i'm gonna read it and learn it for the future. Thanks for your review !

  Ps : i haven't seen that there was probably something below the header component (there is something white below) so yeah, my bad i will get out the overflow-y

  00