Four Card Feature

Community feedback

• 

  Vanessa M.•90

  @mendezpviPosted 8 days ago

  Hi @aeleneh, nice job.

  I have some observations:

  • You can replace some div's with semantic tags:
    • The heading class with a <header> tag.
    • The card-grid class with a <section> tag.
    • Each card can be an <article>.
  • As for the title, I consider it to be one line: Reliable, efficient delivery Powered by Technology
    • You can separate it by wrapping the Powered by Technology part in a <span> and styling it.
  • Avoid styling directly in the HTML.
    • The width and height of the image can be managed from the CSS.
  • Give the <main> a minimum and maximum width in pixels:
    • When you test it in the inspector, it either gets too narrow or it expands too much.

  Here is a link to my solution, which is based on a mobile-first approach. You can take a look at it and maybe you will find some useful information.

  0