Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud that I have been able to recreate the web design using CSS.

What challenges did you encounter, and how did you overcome them?

Making the cards responsive. I opted to use % when defining width and height.

What specific areas of your project would you like help with?

I am using media queries. I do not have a problem with styling small devices (phones) and any large devices (desktop) the problem lies within medium devices (tablets). When I write this : @media only screen and (min-width:600px) { /* lines of code*/} it is breaking the code for desktop (when the width is more than 1200px). That's the problem.

Community feedback

N1Dovud 170

@N1Dovud

Posted

I liked your solution. Here is my feedback:

  1. Add margin bottom to the webpage.
  2. Sometimes your cards look too long, try to use less margin bottom or padding bottom.
  3. I guess your cards are vertically stacked, meaning you are using flex-direction column. What I would suggest is just use flex-direction row and set flex-wrap to wrap without anything else.
  4. If you examine the first paragraph, there are problems with its margins compared to first heading. Fix that.
  5. I think in your box shadow you did not give your cards some spread. Also, probably think about lowering the opacity of the shadow color.
  6. The biggest problem you have is not using semantic html tags. They are very important for SEO and accessibility and screen readers.
  7. I noticed you used too many divs. Try to use as few as possible, although using a lot is not a problem.
  8. Do not use the word "image in your alt attribute in your image tag because the screen reader tells that itself. Give meaningful description to your alts.
  9. Never have the main heading with h2. The heading of the page should I always be h1.
  10. Instead of h3 for sections, you can use h2 because you have not used it anywhere else.
  11. Set box-sizing to border box for all items; it makes working with boxes easier.
  12. Try to avoid setting a certain height to objects even if you are using a relative unit. Height should be a problem in responsiveness, the problem should be the width.
  13. You used too much css for your project. I used only 100 lines of css for which you used 5 times more code. That is probably because you worked on media queries too much. If you want some learning source, I would suggest freecodecamp, where you are given tasks bit by bit and you do them individially, which helps to be code efficient and understand lower level details better. I hope I helped. Have a nice day!
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord