@Flashdaniel
Posted
Nice work. But I like to point out that you worked harder in your CSS.
-
There was no need for
position
property in your CSS code.body
was already properly positioned by the browser. Your struggle was as a result of theposition: absolute
. -
Learn to make proper use of inherited properties in CSS, for less code and avoid duplication.
-
You can learn to make proper use of responsive units (like em, rem, %) in
font-size
,padding
,width
andmargin
. It helps to keep your site responsive if Users chose to resize their browser windows or change browser font size
You can apply full height to the <body>
by doing this
body {
height: 100vh;
}
Or
html {
height: 100%;
}
body {
height: 100%;
}
Marked as helpful