Design comparison
Solution retrospective
I am proud of how I use display grid.
What challenges did you encounter, and how did you overcome them?I struggle with postion of body and his height.
Community feedback
- @FlashdanielPosted 4 months ago
Nice work. But I like to point out that you worked harder in your CSS.
-
There was no need for
position
property in your CSS code.body
was already properly positioned by the browser. Your struggle was as a result of theposition: absolute
. -
Learn to make proper use of inherited properties in CSS, for less code and avoid duplication.
-
You can learn to make proper use of responsive units (like em, rem, %) in
font-size
,padding
,width
andmargin
. It helps to keep your site responsive if Users chose to resize their browser windows or change browser font size
You can apply full height to the
<body>
by doing thisbody { height: 100vh; }
Or
html { height: 100%; } body { height: 100%; }
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord