four card component

Community feedback

• 

  Nader•300

  @youtubbehPosted over 2 years ago

  Hi Mohammed, On first impression, looks good to me! There are some things you can improve, though:

  • There are some typos on your text: MOnitors, avaluate, taent.
  • Using semantic html tags. I would suggest you use <main> instead of <div class="container"> for your main container. <main> is a semantic html tag that better informs the browser what the content is about.
  • Use h2 instead of h3 because you shouldn't skip h tag orders. This is also a semantic html best practice.
  • Be careful to include <alt> tags for accessibility on your images.
  • On mobile, your boxes look a bit squeezed, I would suggest you make the main container's width a bit smaller when screen width gets to 400px or lower. You can do this by adding a media query and in there setting a width for the main container: @media all and (max-width: 400px)...

  Marked as helpful

  1

  ---

  

  mohammed abdo•220

  @Hazard-58Posted over 2 years ago

  @youtubbeh thank you for your advices, I'll try to take it on consider the next time :)

  0