Four Card

Community feedback

• 

  Jordane Gengo•590

  @jgengo-altPosted over 2 years ago

  Hello 👋

  First of all, good job 🚀

  I really like your card hover with the border-top color as a box-shadow, that's pretty smart and looks awesomely great! I would have probably just remove the transform scale, but that's because I'm not a huge fan of div being rescaled while being hovered, compared to some div scaling when scrolling ... but that's just a personal taste :)

  Also, would have been great to use html grid (and their gap) instead of flex (and a margin) for arranging your layout, that would have been a great occasion to learn how to use them if you don't know yet. Still your layout looks dope and you managed to make it works pretty well with flexbox!

  I found also an issue with your layout when I'm around ~900px of width, your leftest card is being cut short/truncated. So it would have been preferable to turn with mobile view around 1050px width or apply an adaptative scaling to your cards.

  Once again, great job my friend 🚀 Keep going you are doing good job!

  Marked as helpful

  0

  ---

  

  Gabriel Felonta De Oliveira•300

  @felontaPosted over 2 years ago

  Hi @jgengo-alt 👋👋, First of all thank you so much for stopping by and checking my code and giving me such amazing feedback, I really have a lot of difficulty with grid html and MediaQueries, but I intend to improve and apply it in future projects and challenges, I really appreciate your feedback, once again thanks .

  0