Design comparison
Community feedback
- @VCaramesPosted about 1 year ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Remove the
header
as there is no need for it in this challenge, as the name implies, this a section of a site.
- Remove the
br
you added to theh1
heading; it is not being used correctly. Instead add amax-width
with ach
value.
- Remove the
section
andaside
; they are being used incorrectly.
-
Using the
article
element is not suitable for wrapping the cards. To utilize the article element effectively, the component should have the ability to stand alone and be independently distributable (usable on another site). -
The icons are purely decorative so their
alt
tag should be left blank (alt=""
).
- This
(min-width: 250px) and (max-width: 420px)
is not necessary; amin-width
is more than enough.
- This is a great challenge to practice using
CSS Grid
. If you are not comfortable using it, here is a link that is all about how to use CSS Grid:
https://css-tricks.com/snippets/css/complete-guide-grid/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0@AlexMdz5620Posted about 1 year ago@vcarames Hello!!! Thanks for the help!!! I already made the pertinent changes and I think it looks better!!!
1 - Remove the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord