you need to remove the height: auto from your container in the mobile layout you end up with your layout not extending the full height of the browser window
Marked as helpful
1
Design comparison
Solution retrospective
Hi everyone, this is my solution to the challenge. I tried to follow the methodology BEM, I don't know if I applied it correctly. If possible, I would like to receive feedback on things that I can improve and that I can correct if I have any errors. Thank you all.
Community feedback
T
ApplePieGiraffe• 30,545
@ApplePieGiraffe
Posted
Hey there, Jacqueline dos Santos Braga! 👋
Good work on this challenge! 👍 Your solution looks pretty nice and is responsive! 😀
I suggest taking a look at your solution report and trying to clear up some of the errors that are there in order to improve the accessibility of your solution. It looks like you need to identify the input elements in the form in some way (you could use the <label> element of the aria-label attribute).
Also, it would be nice if the error messages for the form fields were taken away when new input is entered into them. Currently, the entire form has to be filled out correctly in order for the error messages to disappear, meaning an error message may still be displayed for a form field that actually has new, valid input in it. 😉
Keep coding (and happy coding, too)! 😁
1
@jacque-sbraga
Posted
Hi again, thanks so much for the feedback, I'm trying to make the necessary adjustments to my solution.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord