For this challenge I used HTML and CSS.

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted 7 months ago

  Hello @mardon1dev

  Congrats on finishing another project! Here is my feedback:

  • <main> is a block-level element so it takes up horizontal space by default. There is no need to set width: 100vh to it. It stretches 100% wide by default.
  • Use min-height: 100vh instead height on <main> element. By doing this your element will be at least 100% of the browser height but can be bigger if needed.
  • You shouldn't set height on .card component. Instead let your inner content decide how much space it need and how high your container will be.
  • Text should never be in span or div alone. Always use meaningful element. Change .card-learning and .card-publish to the appropriate elements.
  • Never use pixels for font-size's. Instead use rem which is relative to font-size of the root element (most browsers set it to 16px). Defining your elements font-size in pixels will not respect the user's font-size preferences and therefore your web page will not be user-friendly.
  • Usually line-height is written as a unitless value, like 1.5.

  Have fun!

  Marked as helpful

  4