Design comparison
SolutionDesign
Solution retrospective
I have tried to minimize the distance between the QR code and the background white colour. Need help on this.
Community feedback
- @GombengPosted over 2 years ago
consider using flexbox while layouting, it easier.
https://www.w3schools.com/csS/css3_flexbox.asp
0@bdileepshettyPosted over 2 years ago@Gombeng Thank you for the most valuable information.
0 - @denieldenPosted over 2 years ago
Hi Shetty, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - remove all
margin
from.top-container
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well 😁 Hope this help!
0@bdileepshettyPosted over 2 years ago@denielden Thank you Daniel for the great information. Looking more from you in future ❤😍.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord