Fonts

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  P

  Oluwatoni Odetola•320

  @ToniHunter274Posted over 1 year ago

  Thank you for your suggestions, I'd be sure to implement everything you have talked about in my next project@0xAbdulKhalid

  0
• 

  Oluwole Kosile-Palmer•90

  @Crea8BossPosted over 1 year ago

  Good attempt Oluwatoni!

  I noted the following adjustments you could make to improve the output:

  Accessibility: Add "alt" attribute to your <img> elements. Semantic HTML: Consider wrapping your .container in <main> tag. Styling: Give "body" a background color so that the .container can pop up. Responsiveness: Add media query to make your design responsive on small screens.

  Well done!

  Marked as helpful

  0

  ---

  

  P

  Oluwatoni Odetola•320

  @ToniHunter274Posted over 1 year ago

  Thank you and well done to you too. @Crea8Boss

  0
• 

  Robert Gatt•70

  @n3rub1Posted over 1 year ago

  That's pretty good. I suggest using classes for the css ex. <h1 class = "main title"></h1> and look into how to make the page responsive.

  0