foi usado HTML e CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  ---

  HEADINGS ⚠️:

  ---

  • This solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Dewan Md Shakib Al-Mujib•410

  @DewanshakibPosted over 1 year ago

  Hey, I liked your project. But if u fix some minor problem I think it'll look amazing. I think you forgot to add background color to your project. If you add it, it'll be a great project. If you think it was helpful. Then mark as a helpful suggestion

  Marked as helpful

  0

  ---

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Dewanshakib

  Ask people to mark your comment as helpful

  • A big part of Frontend Mentor is helping each other out and providing feedback. If you give some feedback, please avoid saying things like, "if you found this feedback useful, please mark this comment as helpful".

  ---

  • It places unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided. Feel free to say something like, "I hope you find this helpful", but please avoid asking for your comment to be marked as helpful outright.

  ---

  • I'd recommend you to read community guidelines before posting a comment.

  Thanks for understanding brother

  0

  

  Dewan Md Shakib Al-Mujib•410

  @DewanshakibPosted over 1 year ago

  @0xAbdulKhalid Yes, brother what are you saying. I am very at this sector I don't know a lot of things. I want to help people. So thanks a lot for telling me where I am making mistakes

  0

  

  Dewan Md Shakib Al-Mujib•410

  @DewanshakibPosted over 1 year ago

  @0xAbdulKhalid Brother, can you tell me how you comment on people's projects so brilliantly and so organized.

  0