Skip to content
Submitted almost 2 years ago

fm-qr-code-component

Kenny Ng•400
@kennylun123
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted almost 2 years ago

    Hey there! 👋 Welcome to FEM and congrats on completing your first challenge!🎊🍻

    Here are some suggestions to help improve your code:

    • This <div class="container grid"> is unnecessary ❌.
    • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

    If you have any questions or need further clarification, feel free to reach out to me.

    Happy Coding! 🤖

    0
    Kenny Ng•400
    @kennylun123Posted almost 2 years ago

    @vcarames Thanks for your reply.

    Should i directly apply those styles into <body> instead of creating an extra <div class="container grid">?

    1
    バレンタイン 😈•64,170
    @VCaramesPosted almost 2 years ago

    @kennylun123

    Correct ✅ !

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord