Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

fm-qr-code-component

Kenny Ng 400

@kennylun123

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Welcome to FEM and congrats on completing your first challenge!🎊🍻

Here are some suggestions to help improve your code:

  • This <div class="container grid"> is unnecessary ❌.
  • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🤖

0

Kenny Ng 400

@kennylun123

Posted

@vcarames Thanks for your reply.

Should i directly apply those styles into <body> instead of creating an extra <div class="container grid">?

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord