Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FM-QR-code-component

@Himanshu-Vishwas

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi @Himanshu-Vishwas,

Congratulations 🎉 for completing this challenge, the card looks great. It is great that you used the flex property to center the card. I have some suggestions I want to address:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. To give your box-shadow a lighter look similarly to the design, you can change the box-shadow to this value box-shadow: 10px 10px 20px rgba(0 0 0 / 10%);

Overall, great attempt and wish you the best for your future projects so keep coding 👍.

1

@Himanshu-Vishwas

Posted

@romila2003 Thanks for the suggestion.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord