
Design comparison
SolutionDesign
Please log in to post a comment
Log in with GitHubCommunity feedback
- @matbac85
Hello,
I've just gone through your code and here are my comments and/or advice, bearing in mind that I'm also a beginner.
General
- CSS Reset: Consider using a CSS reset or normalization for consistent rendering across browsers.
- Units: Prefer
rem
orem
units overpx
for scalability and accessibility. - Media Queries: Follow "mobile first" approach, use
rem
units in media queries.
Specific CSS Properties
height
Property: Avoid fixed heights, use percentage or flexible values.width
Property: Prefer relative units for better responsiveness.
CSS Variables
- Usage: Utilize CSS variables for consistency.
Recommendations for Improvement
- Implement CSS reset for consistency.
- Replace fixed dimensions with relative units.
- Use
rem
units in media queries, adopt "mobile first" approach.
good job and keep up the good work !!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord