Fluid QR code component using plain CSS

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 12 months ago

  Hello, good job on the challenge! Here are some tweaks to improve it even further.

  HTML:

  • The alt text also needs to say where it leads (frontendmentor.io).

  • It's most common to have the "Challenge by" as a <footer>, placed underneath the card. The text also needs to be wrapped in a <p>.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • The max-width on the card looks good, but it should be in rem. 320px equals to 20rem.

  • You only need to set text-align: center on the body - remove it elsewhere.

  Marked as helpful

  0

  ---

  

  Josué Zalazar•80

  @josuez2006Posted 12 months ago

  @Islandstone89 thank you so much! They're incredible tips!

  1