float, hover, pseudo-selectors

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Prince, congrats on completing the challenge!

  I had a look at your final solution and I have a few suggestions for you that I hope will be useful:

  • remove all margin from .card class.
  • Note: Flexbox aligns to the size of the parent container.
  • adding this properties for center the card to the body:

  display: flex;
  justify-content: center;
  align-items: center;
  height: 100vh;
  

  Read here -> Flexbox guide

  • Try adding a little transition on the element with hover effect

  In the end, to make it look as close to the design as possible, use the font provided for the challenge: here's a guide on how to import fonts -> Import font

  Overall you did well :) keep it up

  Hope this helps. Happy coding!

  Marked as helpful

  0

  ---

  

  Prince Kumar•70

  @PrinceKumar931Posted almost 3 years ago

  @denielden Hi, thank you very much for pointing out the corrections. I hope you can help me with my upcoming solutions.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @brago87 of course ;)

  0
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @brago87 ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • On smaller devices, card goes over screen, and I think max-width: 100% can solve this issue.
  • I suggest you to try transition on hoverable elements like image, heading and creator name.
  • Please try BEM for naming element classes. It will help you a lot on bigger projects.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  0

  ---

  

  Prince Kumar•70

  @PrinceKumar931Posted almost 3 years ago

  @tymren608 thank you very much Tymur, I m going to correct it as soon as possible.

  0