Flexbox,i don't know Sass

Community feedback

• 

  Shashi Lo•1,345

  @shashiloPosted over 4 years ago

  Good job with the implementation. There's few things I'd like to point out.

  The container should not have a fixed height. A website should have a fluid container so it can handle dynamic assets and content. I would add margin: auto; to the .container to center the website.

  I'm not sure if you purchased the art file, but the line-heights are off. Also, you're missing Raleway font weight 700 in your font import.

  The mobile implementation needs some love, but you're on the right track. You are using too many fixed width elements. Think about making a mobile screen more fluid. Let the container control the max-width of the website and allow the elements to be fluid to the container as it grows and shrinks.

  1

  ---

  

  gulay yolcu•40

  @glayolfdPosted over 4 years ago

  thanks for your comment,i really had a hard time with width and heights..so i'm working for improving my css skills..

  0

  

  Shashi Lo•1,345

  @shashiloPosted over 4 years ago

  @glayolfd We all struggle with pixel perfection. Practice makes perfect!

  0