flexbox,css,html newbie

Community feedback

• 

  Jiro Ricaro•715

  @jiroRiPosted over 4 years ago

  Hi @uzumakiabba! You have a great solution considering that you are very new to css and html! 🤩💯

  I have a few suggestions that may be able to help you:

  • Use the neutral | dark color provided in the style-guide.md for your .heading-sub and your h3 elements.

  • You should dive deeper in Flexbox and learn more about it. It will definitely improve your current solution.

  • With regards to flexbox, try adding a property of it: align-items: center to your .container div, you will already see a huge improvement after doing so.

  Now to expound on what made such a nice change.. by adding the display: flex; property, you will have a property of flex-direction: row; by default(even if you didn't explicitly type it). This means that your main-axis goes horizontally and your cross-axis will go vertically. What align-items: center; does is it aligns the flex items on the cross-axis.

  So, going by your solution, it should center your flex items vertically. Btw, center is one of the property values of align-items and there are more you should look into.

  There are a lot of great things to learn in Flexbox and you should definitely check the Resources Page to dive deeper.

  But overall, you really did a great job!

  Good luck and Keep at it! 💪 - Jiro

  1

  ---

  

  uzumakiabba•80

  @recklessbossPosted over 4 years ago

  @jiroRi thanks for the feedback,i really appreciate it

  0