Design comparison
Community feedback
- Account deleted
Hey there, congratulations on completing the challenge! Your solution is fantastic! 🎉
I did notice one area where you could make some improvements in terms of accessibility and organization of your code. When analyzing your HTML markup, I noticed that the lack of semantic markup resulted in accessibility errors related to landmarks.
To address this issue, I recommend replacing the <div class="attribution"> element with a semantic <footer> element in your index.html file. By doing so, you will create a more structured layout for your webpage, and better communicate its structure and hierarchy to users.
Landmarks are used to define major sections of a webpage, and using them instead of generic elements like <div> or <span> helps to make the code more accessible and easier to navigate for all users. The <footer> element, for instance, is commonly used to contain information about the author, copyright data, or links to related documents.
I hope you find this feedback helpful, and I look forward to seeing how you apply it in future projects. Keep up the great work, and happy coding! 😄
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord