Flexbox

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Nice job on making this project. Viewing your solution, there are things you should considered before submitting it.

  • Use a validator to check your solution, for instance, the HTML structures
  • btn is not a tag. You should replaced it with the proper tag which is button
  • It's common to use div to wrap the contents, for best practice you should use main tag for readability
  • Same goes with the .attribution wrap it with footer
  • Eliminate the link tag a the design doesn't have to be clickable
  • Add an alt to the img tag, put a description of the image

  Overall, you did a great job with the design but put more effort on the code quality. Keep up the good work!

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Zaclobsterboy, good work!

  There is no better way to implement SVG, but please note that the advantage of svg is that they are editable via code, so the best way is in base of case for sure. In this case it is the perfect way to implement it.

  Also, try using Flexbox for center the card on the page: give the flexbox and height properties to the body and remove margin from the .card class.

  Note: Flexbox aligns to the size of the parent container.

  You can use the vh measurement for the height... Viewport Height handles the sizing of an element in relation to the height of the browser window.

  I hope that helps!

  Marked as helpful

  0
• 

  Zaclobsterboy•40

  @ZaclobsterboyPosted almost 3 years ago

  Thanks @denielden for your comments, much appreciated.

  1