@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the
text-transform
property to transform the text to uppercase in CSS -
Use the
<footer>
tag to wrap the footer of the page instead of the<div class="attribution">
-
You could use the
<del>
tag to indicate the price that was before the discount. -
The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information. -
Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty
alt
attribute instead of a descriptive one. You can read more about this here π.If you want to learn more about the
alt
attribute, you can read this article. π.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@TkDevk
Posted
@MelvinAguilar Hi Melvin, thank you for your feedback, i really appreciate the documentation that you shared with me.π