Flex-box

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the text-transform property to transform the text to uppercase in CSS

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">

  • You could use the <del> tag to indicate the price that was before the discount.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here 📘.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Duvan Rodriguez•120

  @TkDevkPosted 10 months ago

  @MelvinAguilar Hi Melvin, thank you for your feedback, i really appreciate the documentation that you shared with me.😀

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @TkDevk!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, don't skip heading levels - start with <h1>, then use <h2>, and so on. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  1

  ---

  

  Duvan Rodriguez•120

  @TkDevkPosted 10 months ago

  @danielmrz-dev Hi, thanks for your feedback, i didn't know that html levels were that important for SEO. I will try it in the next challenge.😁

  0