Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox to make responsive social landing page

P

@TheWraithDev

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What specific areas of your project would you like help with?

Responsiveness

Community feedback

Darkstar 1,070

@DarkstarXDD

Posted

Looks nice. Some suggestions.

  • Always use rem for font-sizes. That way if the user changes their default browser font-size, the text in your website will scale accordingly. This won't happen if you used px for font-sizes.
  • Try to avoid having text inside div or span alone. They are meaningless elements used for grouping or styling purposes. Change that quote text to a p element or better, for a blockquote element. You can use span if you want to select some text that is already inside a p.
  • There should be an anchor (<a>) element inside those list items, because if a user clicked on one of those social media names they should be taken into that site. Otherwise having those social media names there would be useless.
  • That horizontal padding on the list items is huge. Is there a need for much padding? Whenever you are using that big amount of padding, specially in a small component like this, it should be a sign you are doing something wrong.
  • The card shouldn't have a min-width. It should have a max-width if needed. Because of that massive padding and the min-width on the card, the card is not responsive in small screen sizes. Ideally a site should look good (responsive without any overflow issues) until around 320px screen sizes.
  • I would give a small padding to the body so that the card won't hit the edges of the screen.

Marked as helpful

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord