@Miculino
Posted
Congrats on completing the challenge, @ArthurWilliams!
Your solution looks really good, both on desktop and mobile screen sizes. Just a few suggestions based on your final solution and Github code:
-
Make the card a bit smaller on desktop screen sizes - consider adding some padding around it
-
Fix the positioning of the background image on mobile screen size
-
Use more classes in your HTML code - there are still quite a few HTML elements that don't have any classes set on them
-
Consider storing your SCSS variables in a separate file
-
You don't need to set
height: 100%
on html, body, main. You can simply usemin-height: 100vh
Marked as helpful