Flexbox, SASS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work on this challenge, Marco! You've done a really good job and the overall layout for your solution looks great. As you can see from the design comparison there are just some small refinements to do in order to get it looking exactly like the design. Nice work!

  Here are some pointers after taking a look at your code:

  • You've got h1, h2, h4 and h5 headings, but no h3. Be sure not to skip heading levels unnecessarily as this can cause accessibility issues with the content hierarchy.
  • I'd also recommend only ever having a single h1 on any page
  • Your CSS is looking really good. Have you ever tried using min-width media queries instead of max-width? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain.

  I hope this helps. Let me know if you have any questions! 👍

  0

  ---

  

  marcojovanovic•180

  @marcojovanovicPosted almost 5 years ago

  @mattstuddert I am happy that like my solution! By the way, your designs are great, awesome !!!! I did not work any CSS project in past 3-4 months, because I start to learn React, so I expect that want be perfect and take me more time to finish !!! Now, I have plan to do CSS project each day, so I could be prepared for job !!! When you have, time, could you, please, explain to me -> Pixel perfect design <- When I do some project for job, they expect that my solution be exactly pixel perfect ????

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @marcojovanovic "pixel-perfect" is a term that's used fairly loosely. Back in the days where you only had desktop screen sizes and px was the most commonly used unit pixel-perfect was more of a thing. These days, with responsive websites and relative units, nobody expects actual pixel-perfect websites. You're obviously expected to try and get as close to the design as possible at the screen sizes the designs are provided for. But "pixel-perfect" is more just a term to say "pay attention to detail". I hope that helps.

  0

  

  marcojovanovic•180

  @marcojovanovicPosted almost 5 years ago

  @mattstuddert Yes, you explained well !

  0