Submitted about 2 months ago

QR Code Component using Flexbox, SCSS and bem

DalaScript• 380

@DalaScript

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Since I'm not a beginner, I was able to complete the project quickly and efficiently. 🚀✨
My familiarity with the technologies and my experience allowed me to work smoothly and confidently. 😊💻

What challenges did you encounter, and how did you overcome them?

There were no significant difficulties during this project. 🌟
Everything went according to plan, and I was able to implement all features without any major issues. 👍🛠️

What specific areas of your project would you like help with?

While there were no special difficulties, I would love to get advice from others on how I could improve. 🧩👨‍🏫
Feedback on my approach and any suggestions for better practices would be greatly appreciated. 🌟💡

Community feedback

haquanq ®️• 1,585

@haquanq

Posted about 2 months ago

Hello @DalaScript 🙋🙋🙋

Nice work, it looks perfect on the screenshot comparison!!

Here is something you can improve:

When you use article, always give it a title/heading (often h2-h6 - each page must have one h1). In your case, these bold text is obviously the title/heading of the article so you can use h1 instead of p.
You can just leave h1 and p without wrapping it in div and the layout still looks the same (avoid using unnecessary div because div has no semantic) .

Nice work, keep it up!! Happy coding 😁😁😁

Marked as helpful

DalaScript• 380

@DalaScript

Posted about 2 months ago

Hello @haquanq 👋

thank you for your advice🙏

The reason I used the P element was because I set it up, so I gave it font size and font weight and thought it didn't matter. But you're right, for search engines it's better to use heading elements instead of P because it's actually a heading.
That container was for padding left and right, but i change it, and it is now section.

Thank you, I wish you Happy coding too✨

Account Deleted

Great job, keep it up!

DalaScript• 380

@DalaScript

Posted 5 months ago

@saadsawash I appreciate that, thank you!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord