Flexbox responsive social profile.

Community feedback

• 

  MikDra1•6,980

  @MikDra1Posted 2 months ago

  Great job on the code! Here are a few suggestions:

  • The use of box-sizing: border-box; for all elements ensures that padding and borders are included in the element's total width and height, which helps prevent layout issues.

  • Defining custom fonts with @font-face is well done. Consider combining similar font definitions to reduce redundancy. Make sure the font files are optimized for web performance.

  • The body background color #f4d04e is vibrant and effective. Setting width: 100%; ensures the body takes up the full viewport width.

  • Using Flexbox to center the .container is effective, but the fixed height of 60rem might cause issues on smaller screens. Consider using min-height or a responsive unit for better adaptability.

  • The .main-card design with border, box-shadow, and border-radius looks modern and clean. Be mindful of the fixed width and ensure it doesn't affect responsiveness. Using percentage-based widths or max-width could improve flexibility.

  • The .text-card styles for headings and links are well thought out. Ensure text color provides good contrast for readability. The hover effect on links changing color to #f4d04e adds a nice touch.

  • The .author-card styling with Flexbox for alignment is effective. Ensure image sizes and spacing are consistent across devices.

  Hope you found this comment helpful 💗💗💗

  Good job and keep going 😁😊😉

  Marked as helpful

  0
• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…

  • Your heading elements are <h1><h2><h4> missing <h3>, Heading elements should be in sequentially-descending order (e.g., <h1>, <h2>, <h3>) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand.

  • Having a clear and descriptive alt text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines use alt text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images,

  • Using font-display: swap in your @font-face rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear.

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  Marked as helpful

  0