Flexbox, React

Community feedback

• 

  Marcelo Formentão•15

  @marceloavfPosted almost 5 years ago

  Hey Lee,

  Awesome solution you've done! Just some tips to help you improve your code and design:

  • When using react, try to use prettier or editorconfig to help your code indentation, this can really improve your code writing and also catch bugs/bad codes easily.
  • When working with a sketch file or design guide, try to keep on eye on details like a shadow, font size, margins, and even border, this will make your work stand out.
  • Function names should say what they do, for example, this changeCss() function could be something setTheme(), that's can really help you when the project gets big.
  • Take a look at PropTypes in react, this can help you document your props and improve your code.

  You can take a look at Clean code tips.

  Congratulations and keep it up!

  1

  ---

  

  P

  Lee•495

  @leecockcroftPosted almost 5 years ago

  @marceloavf Appreciate the comments :) Thank you

  1