Design comparison
SolutionDesign
Solution retrospective
Any feedback would be appreciated.
Community feedback
- @juanpb96Posted over 3 years ago
Hi Tomiwa.
Good job on you solution 🙌.
I have a suggestion for you:
- You can add a
span
to your anchor tag for social media icons. This is a way to put text there and give screen readers the possibility to know the meaning of the icon and increase your accessibility score. - If you want to do what I suggested above, then you will need to implement a class that hides that text from the design, I recommend this:
.sr-only { width: 1px; height: 1px; position: absolute; margin: -1px; padding: 0; overflow: hidden; }
Hope that helps. Happy coding! 🥳
Marked as helpful1 - You can add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord