Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

flexbox

Mark 170

@Mark-a-obrien

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I found sizing the image to be difficult because i couldn't get it to auto adjust the size depending on the parent element width.

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi @Mark-a-obrien, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- Document should have one main landmark, you could have put all the content inside the main tag click here

To further improve the responsiveness of the project, I added a media query to make the layout fully responsive.

@media (max-width: 330px) { .area { width: 100%; } #qr { width: 100%; height: 100%; } }

The rest is great! Hope it helps... 👍

Marked as helpful

1

Mark 170

@Mark-a-obrien

Posted

@AdrianoEscarabote Hello Adriano, Thank you very much for the feedback. I will deffinelty use main from now and I'll use that media query for this projects.

Thanks agian

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord