Skip to content
Submitted almost 3 years ago

Flexbox

Daniel•680
@DanielArzani
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

The piece of text that said "Improve your front-end skills by building projects", should I have put that in a <span> rather than a <p> tag?

Community feedback

  • Mushfiq Rahman•300
    @Ayon95Posted almost 3 years ago

    Hi, your solution looks good. "Improve your front-end skills by building projects" is the title of this card, so an <h2> or an <h3> tag would be a much better option than <span> and <p>. Also, you can improve the HTML markup by using an <article> tag instead of <section> for the card. The main content of the page should go inside <main> tags. These changes will get rid of a lot of the accessibility and HTML issues.

    <body>
  <main>
    <article class="card">
    </article>
  </main>
  <footer>
  </footer>
</body>
    1
  • Account deleted

    Good job Daniel 👋

    I will teach a very cool trick for you 😀. Use span to change part of the text that is inside p or hx tags. Like to add underline or make it blue.

    Remember span is something like div tag but for texts 😉

    Cheers Maqsud

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord