flexbox overlay positioning

Community feedback

• 

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  Hi @Ahmed-Elsayed-projects, how are you?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  2- Page should contain a level-one heading click here

  3- Links must have discernible text

  Context: <a href="//htmlpreview.github.io/?https://github.com/Ahmed-Elsayed-projects/frontendmentor/blob/main/nft-preview-card-component-main/index.html#" > click here to read about it

  Hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Ahmed•150

  @Ahmed-Elsayed-projectsPosted about 2 years ago

  @AdrianoEscarabote Thank you for the feedback. I'll use them in next challenge.

  1

  

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  @Ahmed-Elsayed-projects no problem, keep coding

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Ahmed,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  • For any decorative svgs , each svg tag should have aria-hidden="true" and focusable=”false”attributes to make all web assistive technologies such as screen reader ignore those images in(icon-view, icon-ethereum, icon-clock ).

  • The link wrapping the equilibrium image (image-equilibrium ) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • Images must have alt attribute. Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  Hopefully this feedback helps.

  0

  ---

  

  Ahmed•150

  @Ahmed-Elsayed-projectsPosted about 2 years ago

  @PhoenixDev22 Thanks so much, I really appreciate your feedback.

  0