flexbox + moder css :D

Community feedback

• 

  _nehal💎•6,710

  @NehalSahu8055Posted about 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.

  <picture>
  <source media="(min-width:800px)" srcset="yourimage.jpg">
  <img src="yourimage.jpg" alt="description">
  </picture>
  

  • For non-decorative images give meaningful and descriptive alt like alt= "Gabrielle Chanel Perfume bottle surrounded by leaves.".

  • Use semantic element for strike-through <s>$169.99</s>

  • Use <button></button> for button as it a semantic element

  • If you want to dive into accessibility for this project check this link

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  0

  ---

  

  JesnerW•210

  @JesnerWPosted about 1 year ago

  @NehalSahu8055 I used a div as a button for the reason that the icon could not move freely inside the button because the icon is one pixel higher to be as accurate as possible. thanks for the recommendation of <s></s>, also <picture>.

  0