flexbox, mobilefirst, media queries

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted almost 3 years ago

  1- Using shorthand properties minimizes the amout of code you need to write, for intace setting padding with padding: top right bottom left.

  2- Add some side padding to you container around 700px and 1000px, there's no empty space between the viewport and the container.

  3- Span is a inline container, a p tags fits the description more accuratly because of its semantics, the description is a paragraph of text.

  4- When images have a purely decorative purpose you can set the alt to an empty string.

  Keep coding :=)

  Marked as helpful

  0

  ---

  

  P

  Diego Serrano•180

  @dserranoiPosted almost 3 years ago

  @MojtabaMosavi Thanks for such detailed feedback, def something to consider in the next challenges and on daily basis coding. Def is worth to implement such recommendations on this current challenge.

  0