Design comparison
Solution retrospective
let me know your feedback
Community feedback
- @MojtabaMosaviPosted almost 3 years ago
1- Using shorthand properties minimizes the amout of code you need to write, for intace setting padding with
padding: top right bottom left
.2- Add some side padding to you container around 700px and 1000px, there's no empty space between the viewport and the container.
3- Span is a inline container, a p tags fits the description more accuratly because of its semantics, the description is a paragraph of text.
4- When images have a purely decorative purpose you can set the alt to an empty string.
Keep coding :=)
Marked as helpful0@dserranoiPosted almost 3 years ago@MojtabaMosavi Thanks for such detailed feedback, def something to consider in the next challenges and on daily basis coding. Def is worth to implement such recommendations on this current challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord