Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

flex-box; media-query

@activus-d

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would love to have some feedback on the background and if there are other methods to rotate and duplicate backgrounds

Community feedback

Agustin 340

@agusc01

Posted

Hi Mohammed.

Get used to putting quotes around URLs (they are strings) For me it is not a good idea how to structure the CSS, try to learn a methodology, like BEM Learn BEM.

For me "BEM" makes everything easier, based on your files if you change the order of the tags in the HTML you can have a real disaster

This: main { height: 100vh; }

It is put more than once in different media queries, the idea of the media query is if the dimension changes change a property, it does not make sense that you always put it with the same pairs of properties and values with once is enough if it is not modified .

This is a very personal point of view but try to do it "Mobile First" then move on to larger devices, I repeat that it is something personal, for me it is easier to start with something small and make it big than to start big and not be able to shrink

Note: you can enter my profile and see how I did this challenge

Remember, Practices makes perfect !

Marked as helpful

0

@activus-d

Posted

@agusc01 thank you for the feed back

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord