Design comparison
Solution retrospective
Tell me please the problems you can see in this website !
Community feedback
- @HassiaiPosted almost 2 years ago
To center a content on a page, declare the following in the body: body{min-height:100vh; display: flex; justify-content center; align-items center;}. Use the colors that were given in the styleguide.md in the starter folder. For a sub div in the main replace the id with a class. In your code the most divs must have the same padding, group all those divs by their classes or id s and give the m one padding value. no need to give the #twoDivs color of white just declare display: flex; There is no need for a margin value in your media query, give it the body a percentage width value of either 80 or 90. I enjoyed reading your code. Hope am helpful. HAPPY CODING
Marked as helpful1@Z-NajdaouiPosted almost 2 years ago@Hassiai Thanks Hassal, I Edited all this notes, I hope if you can take a look again. (I didn't found colors in stylequide.md so of cours it's not same)
0@HassiaiPosted almost 2 years ago@Z-Najdaoui you did an awesome wok, just change the width of the main fr0m 70% to 50%. this should be good. Well done. Happy coding
Marked as helpful0@HassiaiPosted almost 2 years ago@Z-Najdaoui WELL DONE, congrats for completing the challenge you did a great job
0 - @eewa-SANJPosted almost 2 years ago
The overall look of the website is great to me. Suggestion: When you write CSS properties try to write them according to an alphabetical manner that will increase the readability o the code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord