Flexbox, media query

Community feedback

• 

  Hafizan Adli•1,190

  @hafizanadliPosted about 3 years ago

  Great work, it's close to design and responsive enough.

  here my suggestions:

  • Avoid skipping heading levels: always start from <h1>, followed by <h2> and so on.
  • Use semantic HTML (main,section,header,footer etc) instead only using div tag

  keep up the good work!

  Marked as helpful

  1

  ---

  

  Zeiyar Lynn•335

  @Zeiyar-LynnPosted about 3 years ago

  @hafizanadli Thanks for your feedback!

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey,

  First of all, congrats on your first upload, it's a really good start! But here are a few things you could do:

  1. You don't need to give your body element a class as there can only be one of them in each html document.

  2. The div you named main could actually be swapped for main element to be more semantic.

  3. Instead of pixels, most of the time it's better to use relative units like em, rem, ch, etc.

  4. If you want to improve responsiveness, you could use min-height, max-width, etc instead of setting these things in stone with width and height properties.

  5. Filling out your README is a nice way to show you put effort in your work and also to reflect on what you've learned ^^

  1

  ---

  

  Zeiyar Lynn•335

  @Zeiyar-LynnPosted about 3 years ago

  @FluffyKas Thanks for your feedback!

  0