@DylandeBruijn
Posted
@Kaytorah
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Be careful with setting a fixed
width
andheight
on your elements. If the content in these elements grows beyond these restrictions youβll run into overflow issues. Keeping theheight
atauto
- whichblock
elements are by default - will be fine in most cases. -
You donβt need to put
width: 100%
onblock
elements, they already take up the full width of their parents by default. -
Try putting your links in a list (
ul
) to make your code more semantic. You made the right choice usinga
tags for your links. Generally you would usea
tags if you want to link to a different page or website and buttons if you want something to happen on the page. You can makea
tags look like a button which is what you want to do here.
Example of code:
<ul>
<li>
<a href="#">Github</a>
</li>
</ul>
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@CelineJames
Posted
Thank you, I will try all these out@DylandeBruijn