@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution contains some minor semantic issues which may cause lack accessibility
- The old price is not being properly announced, you have used
span
element for that.
- Actually there's a native html element which comes handy in these situations. it is
del
element
- So you can use like this
<del>$169.99</del>
- These are the tips which improves the accessibility in real world situations.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@sh0910
Posted
Thanks for taking the time to review my code and offer suggestions; they are helpful! I will add the del element and sr-only utility in my project.