flexbox

Community feedback

• 

  Dylan Heslop•1,570

  @dylan-dot-cPosted 2 days ago

  Looking good! ou used semantic html but it could be extended a bit.

  • You could make those 2 divs section elements just to be more semantic.
  • You have used margin to put all the content away from the edge, it better to just put a padding on the main container and that will eliminate the need for the weird margin you put on the texts and the image. Also note you should use the box-sizing property and set it to border-box what this does is that whatever width you specify for a container it will make the padding a part of that width, ie: width of a div is 200px but there is a padding: 20px on it, without box-sizing it would add the padding to the width thus make it(200+20(leftpad)+20(rightpad) = 240px, but with border-box it will let padding take up space from the 200px so no matter how much padding you add it will remain 200px.

  Well done, take a look at my challenge and see how I did mine

  Marked as helpful

  0

  ---

  

  shaikh zayed•50

  @undersigned-devPosted 1 day ago

  @dylan-dot-c thanks for the review i tried doing as you asked can you inspect again and tell me if i did it correctly

  0