Design comparison
Solution retrospective
Feel free to check out my code (particularly my CSS) and tell me what you think of my style (organization of my code). That feedback will very much be appreciated.
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hey there, Kevin! π
I'm sorry I'm sooo late! π I finally came to check out your solution and all I can say is well done on this challenge! π You've definitely improved and your solution is looking good! π
I just noticed that the card component is a bit wide when the layout first switches from desktop to mobile. You might want to add a max-width to the card in the mobile layout so that it isn't so wide when the layout first changes. π
I'm looking forward to seeing your solutions to some of the harder challenges! π And keep on learning JS! π
Bruh, you already knowβkeep coding (and happy coding, too)! π
Marked as helpful3@tesla-ambassadorPosted over 3 years ago@ApplePieGiraffe Hey Bro, thanks for the feedback. I will be sure to add the max-width on the card in the mobile layout. It was looking a bit weird thanks for solving the problem. And am learning JS real hard! I might surprise you with a better challenge one of these days.π keep coding (and happy coding, too!)π
1 - @dstrickl7Posted over 3 years ago
Hi tesla-ambassador! I checked out your CSS code and I think it's logically organized and I think the comments helped with setting up the framework.
Some things I'd like to suggest for the visual aspects of your solution: -If the purple color is pre-defined try using that instead of the default css purple to match the design more closely. -For your images overlay, raise the opacity to around 0.7.
Overall, nice work! Keep coding!
1@tesla-ambassadorPosted over 3 years ago@dstrickl7 Thank you so much, I have just realized that the purple accent I used is actually lighter than the original one. Thanks a bunch once again.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord